[webkit-reviews] review requested: [Bug 190402] [iOS] Cleanup -[WAKView _selfHandleEvent:] and -[WAKWindow sendEventSynchronously:] : [Attachment 351885] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 9 10:07:18 PDT 2018


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 190402: [iOS] Cleanup -[WAKView _selfHandleEvent:] and -[WAKWindow
sendEventSynchronously:]
https://bugs.webkit.org/show_bug.cgi?id=190402

Attachment 351885: Patch

https://bugs.webkit.org/attachment.cgi?id=351885&action=review




--- Comment #2 from Daniel Bates <dbates at webkit.org> ---
Created attachment 351885

  --> https://bugs.webkit.org/attachment.cgi?id=351885&action=review

Patch

More clean up of -[WAKView _selfHandleEvent:]. Inline a local variable into the
swithc condition, change break statements to return statements and remove the
return statement at the end of the function as the compiler is capable of
verifing that the switch block handles all enumerators.


More information about the webkit-reviews mailing list