[webkit-reviews] review granted: [Bug 190342] [Cocoa] [WK2] Add support for text alignment and text lists in font attributes : [Attachment 351758] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 190342: [Cocoa] [WK2] Add support for text alignment and text lists in font
attributes
https://bugs.webkit.org/show_bug.cgi?id=190342

Attachment 351758: Patch

https://bugs.webkit.org/attachment.cgi?id=351758&action=review




--- Comment #8 from Tim Horton <thorton at apple.com> ---
Comment on attachment 351758
  --> https://bugs.webkit.org/attachment.cgi?id=351758
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351758&action=review

> Source/WebCore/PAL/pal/spi/cocoa/NSAttributedStringSPI.h:110
> +#if PLATFORM(IOS) || (PLATFORM(MAC) && __MAC_OS_X_VERSION_MAX_ALLOWED <
101300)

Are these exported? Should they be like all the other constants above (other
than NSSuperscript)?