[webkit-reviews] review granted: [Bug 190371] [iOS] Ignore some deprecated declarations : [Attachment 351814] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 15:18:44 PDT 2018


mitz at webkit.org has granted Daniel Bates <dbates at webkit.org>'s request for
review:
Bug 190371: [iOS] Ignore some deprecated declarations
https://bugs.webkit.org/show_bug.cgi?id=190371

Attachment 351814: Patch

https://bugs.webkit.org/attachment.cgi?id=351814&action=review




--- Comment #2 from mitz at webkit.org ---
Comment on attachment 351814
  --> https://bugs.webkit.org/attachment.cgi?id=351814
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351814&action=review

rs=me

> Source/WebKit/UIProcess/ios/WKActionSheet.mm:55
> +#pragma clang diagnostic push
> +#pragma clang diagnostic ignored "-Wdeprecated-declarations"

Please use the ALLOW_DEPRECATED_DECLARATIONS_{BEGIN,END} macros instead.


More information about the webkit-reviews mailing list