[webkit-reviews] review canceled: [Bug 189162] Make <input type=color> a runtime enabled (on-by-default) feature : [Attachment 351810] Rebase on trunk

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has canceled Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 189162: Make <input type=color> a runtime enabled (on-by-default) feature
https://bugs.webkit.org/show_bug.cgi?id=189162

Attachment 351810: Rebase on trunk

https://bugs.webkit.org/attachment.cgi?id=351810&action=review




--- Comment #14 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 351810
  --> https://bugs.webkit.org/attachment.cgi?id=351810
Rebase on trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=351810&action=review

>> Source/WebKit/Shared/WebPreferences.yaml:1393
>> +  humanReadableName: "Input type color"
> 
> This is not a good name for the menu

=> "Color Inputs"

>> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:158
>> +	return _webDelegate.get().get();
> 
> I think this should be getAutoreleased.

👍