[webkit-reviews] review denied: [Bug 150005] Web Inspector: show redirect requests in Network and Timelines tabs : [Attachment 351420] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 12:42:07 PDT 2018


Brian Burg <bburg at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 150005: Web Inspector: show redirect requests in Network and Timelines tabs
https://bugs.webkit.org/show_bug.cgi?id=150005

Attachment 351420: Patch

https://bugs.webkit.org/attachment.cgi?id=351420&action=review




--- Comment #16 from Brian Burg <bburg at apple.com> ---
Comment on attachment 351420
  --> https://bugs.webkit.org/attachment.cgi?id=351420
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351420&action=review

This looks good overall, but it no longer applies to TOT so I couldn't test it
out.

> Source/WebCore/inspector/agents/InspectorNetworkAgent.cpp:201
> +    auto elapsedTimeSince = [&] (const MonotonicTime& time) {

Nice.


More information about the webkit-reviews mailing list