[webkit-reviews] review granted: [Bug 190333] [Payment Request] Requests should be aborted after details settle when the user cancels : [Attachment 351736] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has granted Andy Estes
<aestes at apple.com>'s request for review:
Bug 190333: [Payment Request] Requests should be aborted after details settle
when the user cancels
https://bugs.webkit.org/show_bug.cgi?id=190333

Attachment 351736: Patch

https://bugs.webkit.org/attachment.cgi?id=351736&action=review




--- Comment #3 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 351736
  --> https://bugs.webkit.org/attachment.cgi?id=351736
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351736&action=review

> Source/WebCore/Modules/paymentrequest/PaymentRequest.cpp:668
>  void PaymentRequest::whenDetailsSettled(std::function<void()>&& callback)

Please use WTF::Function or WTF::CompletionHandler