[webkit-reviews] review granted: [Bug 178153] Web Inspector: Open Resource Dialog should show path to resource (to disambiguate resources with same name) : [Attachment 351586] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 09:26:24 PDT 2018


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 178153: Web Inspector: Open Resource Dialog should show path to resource
(to disambiguate resources with same name)
https://bugs.webkit.org/show_bug.cgi?id=178153

Attachment 351586: Patch

https://bugs.webkit.org/attachment.cgi?id=351586&action=review




--- Comment #5 from Brian Burg <bburg at apple.com> ---
Comment on attachment 351586
  --> https://bugs.webkit.org/attachment.cgi?id=351586
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351586&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/OpenResourceDialog.css:181
> +.open-resource-dialog .tree-outline.large .item .titles[data-path]::after {

Clever! I have never used Element.dataset.


More information about the webkit-reviews mailing list