[webkit-reviews] review granted: [Bug 189606] Web Inspector: group media network entries by the node that triggered the request : [Attachment 351728] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 8 08:52:15 PDT 2018


Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 189606: Web Inspector: group media network entries by the node that
triggered the request
https://bugs.webkit.org/show_bug.cgi?id=189606

Attachment 351728: Patch

https://bugs.webkit.org/attachment.cgi?id=351728&action=review




--- Comment #45 from Brian Burg <bburg at apple.com> ---
Comment on attachment 351728
  --> https://bugs.webkit.org/attachment.cgi?id=351728
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351728&action=review

r=me, great work!

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:818
> +	   // If the entry has an `initiatorNode`, use that node's "first"
resource as the value of

Thanks.

> Source/WebInspectorUI/UserInterface/Views/NetworkTableContentView.js:821
> +	   // next to eachother, as they will all effectively be sorted by the
first resource.

Nit: each other


More information about the webkit-reviews mailing list