[webkit-reviews] review granted: [Bug 189239] [EME][GStreamer] Add support for WebM encrypted caps "application/x-webm-enc" : [Attachment 351771] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 189239: [EME][GStreamer] Add support for WebM encrypted caps
"application/x-webm-enc"
https://bugs.webkit.org/show_bug.cgi?id=189239

Attachment 351771: Patch

https://bugs.webkit.org/attachment.cgi?id=351771&action=review




--- Comment #16 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 351771
  --> https://bugs.webkit.org/attachment.cgi?id=351771
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351771&action=review

>
Source/WebCore/platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer
.cpp:61
>      GST_STATIC_CAPS("application/x-cenc,
original-media-type=(string)video/x-h264, protection-system=(string)"
WEBCORE_GSTREAMER_EME_UTILITIES_CLEARKEY_UUID "; "
> -    "application/x-cenc, original-media-type=(string)audio/mpeg,
protection-system=(string)" WEBCORE_GSTREAMER_EME_UTILITIES_CLEARKEY_UUID));
> +    "application/x-cenc, original-media-type=(string)audio/mpeg,
protection-system=(string)" WEBCORE_GSTREAMER_EME_UTILITIES_CLEARKEY_UUID";"
> +    "application/x-webm-enc, original-media-type=(string)video/x-vp8;"
> +    "application/x-webm-enc, original-media-type=(string)video/x-vp9;"));

(In reply to Yacine Bandou from comment #14)
> Encrypted MP4/VP9 --> qtdemux with src caps "application/x-cenc,
> original-media-type=(string)video/VP9".

Again, why did	you decide to leave outside the question "application/x-cenc,
original-media-type=(string)video/VP9"	cause from current code I see it is not
supported. Well, anyway, this would not belong to this patch, so I'll r+ it.