[webkit-reviews] review denied: [Bug 189239] [EME][GStreamer] Add support for WebM encrypted caps "application/x-webm-enc" : [Attachment 351599] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Yacine Bandou
<bandou.yacine at gmail.com>'s request for review:
Bug 189239: [EME][GStreamer] Add support for WebM encrypted caps
"application/x-webm-enc"
https://bugs.webkit.org/show_bug.cgi?id=189239

Attachment 351599: Patch

https://bugs.webkit.org/attachment.cgi?id=351599&action=review




--- Comment #7 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 351599
  --> https://bugs.webkit.org/attachment.cgi?id=351599
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351599&action=review

>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1292
> +	   (eventKeySystemUUID == GST_PROTECTION_UNSPECIFIED_SYSTEM_ID) ?
weakThis->m_player->initializationDataEncountered("webm"_s,
ArrayBuffer::create(reinterpret_cast<const uint8_t*>(initData.characters8()),
initData.sizeInBytes())) :
weakThis->m_player->initializationDataEncountered("cenc"_s,
ArrayBuffer::create(reinterpret_cast<const uint8_t*>(initData.characters8()),
initData.sizeInBytes()));

It would be much simpler to write:

weakThis->m_player->initializationDataEncountered(eventKeySystemUUID ==
GST_PROTECTION_UNSPECIFIED_SYSTEM_ID) ? "webm"_s : "cenc"_s,
ArrayBuffer::create(reinterpret_cast<const uint8_t*>(initData.characters8()),
initData.sizeInBytes()));

>
Source/WebCore/platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorG
Streamer.cpp:162
> +	       (!g_strcmp0(klass->protectionSystemId,
GST_PROTECTION_UNSPECIFIED_SYSTEM_ID)) ?
gst_structure_set_name(outgoingStructure.get(), "application/x-webm-enc") :
gst_structure_set_name(outgoingStructure.get(), "application/x-cenc");

gst_structure_set_name(outgoingStructure.get(),
g_strcmp0(klass->protectionSystemId, GST_PROTECTION_UNSPECIFIED_SYSTEM_ID) ?
"application/x-cenc" : "application/x-webm-enc");