[webkit-reviews] review granted: [Bug 190334] Adding some temporary asserts with data logging to debug a mysterious ASAN bot crash. : [Attachment 351737] proposed patch.

[bugzilla-daemon at webkit.org]

Yusuke Suzuki <yusukesuzuki at slowstart.org> has granted Mark Lam
<mark.lam at apple.com>'s request for review:
Bug 190334: Adding some temporary asserts with data logging to debug a
mysterious ASAN bot crash.
https://bugs.webkit.org/show_bug.cgi?id=190334

Attachment 351737: proposed patch.

https://bugs.webkit.org/attachment.cgi?id=351737&action=review




--- Comment #3 from Yusuke Suzuki <yusukesuzuki at slowstart.org> ---
Comment on attachment 351737
  --> https://bugs.webkit.org/attachment.cgi?id=351737
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=351737&action=review

r=me with a nit.

> Source/WTF/wtf/StackBounds.cpp:152
> +    else {

I think using `if (stackDirection() == StackDirection::Downward)` here would be
more readable.