[webkit-reviews] review granted: [Bug 190327] [Xcode] Never build yasm with ASAN : [Attachment 351719] Opt yasm out of ASAN

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted mitz at webkit.org's request for
review:
Bug 190327: [Xcode] Never build yasm with ASAN
https://bugs.webkit.org/show_bug.cgi?id=190327

Attachment 351719: Opt yasm out of ASAN

https://bugs.webkit.org/attachment.cgi?id=351719&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 351719
  --> https://bugs.webkit.org/attachment.cgi?id=351719
Opt yasm out of ASAN

View in context: https://bugs.webkit.org/attachment.cgi?id=351719&action=review

> Tools/asan/asan.xcconfig:16
> +CLANG_ADDRESS_SANITIZER_NO = YES;

Is it working?
Should we set WK_ASAN_ALLOWED = NO in yasm.xcconfig and 
CLANG_ADDRESS_SANITIZER = $(CLANG_ADDRESS_SANITIZER_$(WK_ASAN_ALLOWED));
CLANG_ADDRESS_SANITIZER_NO = NO;