[webkit-reviews] review denied: [Bug 190321] Cache API tests are flaky due to file writing failing from time to time : [Attachment 351695] Patch

[bugzilla-daemon at webkit.org]

Alex Christensen <achristensen at apple.com> has denied youenn fablet
<youennf at gmail.com>'s request for review:
Bug 190321: Cache API tests are flaky due to file writing failing from time to
time
https://bugs.webkit.org/show_bug.cgi?id=190321

Attachment 351695: Patch

https://bugs.webkit.org/attachment.cgi?id=351695&action=review




--- Comment #2 from Alex Christensen <achristensen at apple.com> ---
Comment on attachment 351695
  --> https://bugs.webkit.org/attachment.cgi?id=351695
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351695&action=review

> Source/WebKit/NetworkProcess/cache/CacheStorageEngine.cpp:386
> +void Engine::writeFile(const String& folderPath, const String& filename,
NetworkCache::Data&& data, WebCore::DOMCacheEngine::CompletionCallback&&
callback)

Shouldn't folderPath be derivable from filename?

> Source/WebKit/NetworkProcess/cache/NetworkCacheStorage.cpp:1029
> +	   RunLoop::main().dispatch([protectedThis = WTFMove(protectedThis),
completionHandler = WTFMove(completionHandler)]() mutable {
> +	       completionHandler();

RunLoop::main().dispatch(WTFMove(completionHandler));