[webkit-reviews] review granted: [Bug 190275] Web Inspector: use iframe's name attribute for FrameTreeElement : [Attachment 351582] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Devin Rousso
<drousso at apple.com>'s request for review:
Bug 190275: Web Inspector: use iframe's name attribute for FrameTreeElement
https://bugs.webkit.org/show_bug.cgi?id=190275

Attachment 351582: Patch

https://bugs.webkit.org/attachment.cgi?id=351582&action=review




--- Comment #6 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 351582
  --> https://bugs.webkit.org/attachment.cgi?id=351582
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351582&action=review

r=me

> Source/WebInspectorUI/UserInterface/Views/ResourceTreeElement.js:136
> +    get _mainTitleText()

I think the underscore is unnecessary. I think of underscore'd things as
properties, not as getters, so this messes with my brain a bit.