[webkit-reviews] review granted: [Bug 190302] Expose whether WKWebProcessPlugInNodeHandle is a select element to clients : [Attachment 351653] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 22:35:35 PDT 2018


Tim Horton <thorton at apple.com> has granted Zach Li <zacharyli323 at gmail.com>'s
request for review:
Bug 190302: Expose whether WKWebProcessPlugInNodeHandle is a select element to
clients
https://bugs.webkit.org/show_bug.cgi?id=190302

Attachment 351653: Patch v1

https://bugs.webkit.org/attachment.cgi?id=351653&action=review




--- Comment #3 from Tim Horton <thorton at apple.com> ---
Comment on attachment 351653
  --> https://bugs.webkit.org/attachment.cgi?id=351653
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=351653&action=review

>
Tools/TestWebKitAPI/Tests/WebKitCocoa/InjectedBundleNodeHandleIsSelectElement.m
m:45
> +    WKDOMElement *htmlElement = [document createElement:htmlElementTag];

I don’t know this API well enough; what’s the ownership story for this object
returned from a -create method?


More information about the webkit-reviews mailing list