[webkit-reviews] review granted: [Bug 190282] A Document / Window should lose its browsing context as soon as its iframe is removed from the document : [Attachment 351630] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Chris Dumez <cdumez at apple.com>'s
request for review:
Bug 190282: A Document / Window should lose its browsing context as soon as its
iframe is removed from the document
https://bugs.webkit.org/show_bug.cgi?id=190282

Attachment 351630: Patch

https://bugs.webkit.org/attachment.cgi?id=351630&action=review




--- Comment #9 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 351630
  --> https://bugs.webkit.org/attachment.cgi?id=351630
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351630&action=review

>
LayoutTests/fast/dom/Window/resources/dom-access-from-closure-iframe-child.html
:2
> +    p = parent; // Save parent as the window will be detached when
accessFrame() is called.

Can we do const parent = window.parent instead?

>
LayoutTests/fast/dom/Window/resources/dom-access-from-closure-window-child.html
:2
> +    o = opener; // Save opener as the window will be detached when
accessFrame() is called.

Ditto.

> LayoutTests/fast/parser/resources/set-parent-to-javascript-url.html:2
> +p = parent;

Ditto.