[webkit-reviews] review granted: [Bug 190289] [macOS] Fix some font attribute conversion bugs in preparation for "Font > Styles…" support in WebKit2 : [Attachment 351626] Add rdar to ChangeLog

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 14:52:36 PDT 2018


Ryosuke Niwa <rniwa at webkit.org> has granted Wenson Hsieh
<wenson_hsieh at apple.com>'s request for review:
Bug 190289: [macOS] Fix some font attribute conversion bugs in preparation for
"Font > Styles…" support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=190289

Attachment 351626: Add rdar to ChangeLog

https://bugs.webkit.org/attachment.cgi?id=351626&action=review




--- Comment #7 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 351626
  --> https://bugs.webkit.org/attachment.cgi?id=351626
Add rdar to ChangeLog

View in context: https://bugs.webkit.org/attachment.cgi?id=351626&action=review

Nice bug fixes!

> Source/WebCore/ChangeLog:19
> +	   Currently, we bail from adding a font shadow if the shadow's offset
is empty. However, valid shadow offsets may
> +	   have negative dimensions, so a check for `isZero()` should be used
instead.

It's very strange / unintuitive that isEmpty() returns true for negative
offsets...

> Source/WebCore/ChangeLog:26
> +	   transparent color (this scenario is exercised when using "Font >
Stylesâ¦" to specify a font style without a

What's up with "â¦"?


More information about the webkit-reviews mailing list