[webkit-reviews] review denied: [Bug 190230] Web Inspector: REGRESSION(r236540): Uncaught Exception: TypeError: pauseReasonBreakpointTreeElement.removeStatusImage is not a function. : [Attachment 351463] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Oct 4 12:17:40 PDT 2018


Matt Baker <mattbaker at apple.com> has denied Devin Rousso <drousso at apple.com>'s
request for review:
Bug 190230: Web Inspector: REGRESSION(r236540): Uncaught Exception: TypeError:
pauseReasonBreakpointTreeElement.removeStatusImage is not a function.
https://bugs.webkit.org/show_bug.cgi?id=190230

Attachment 351463: Patch

https://bugs.webkit.org/attachment.cgi?id=351463&action=review




--- Comment #5 from Matt Baker <mattbaker at apple.com> ---
Comment on attachment 351463
  --> https://bugs.webkit.org/attachment.cgi?id=351463
Patch

r-, since a little investigating revealed the problem is with our wacky tree
element class hierarchy, not event breakpoints specifically. The bug also
reproduces with DOM breakpoints and (I assume) XHR breakpoints. I think the
correct fix should resolve the general problem affecting all three.


More information about the webkit-reviews mailing list