[webkit-reviews] review granted: [Bug 190271] Add a switch for Web SQL : [Attachment 351575] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Sihui Liu <sihui_liu at apple.com>'s
request for review:
Bug 190271: Add a switch for Web SQL
https://bugs.webkit.org/show_bug.cgi?id=190271

Attachment 351575: Patch

https://bugs.webkit.org/attachment.cgi?id=351575&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 351575
  --> https://bugs.webkit.org/attachment.cgi?id=351575
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351575&action=review

> Source/WebKit/Shared/WebPreferences.yaml:1364
> +  webcoreBinding: RuntimeEnabledFeatures

Don't we need a category? What's the default category if you do not specify
one?

> Source/WebKit/UIProcess/API/C/WKPreferencesRef.h:332
> +WK_EXPORT bool WKPreferencesGetWebSQLEnabled(WKPreferencesRef
preferencesRef);

Do we really need this SPI?