[webkit-reviews] review granted: [Bug 190018] Runtime flag and IDL for MediaRecorder : [Attachment 351576] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Wendy <yuhan_wu at apple.com>'s request
for review:
Bug 190018: Runtime flag and IDL for MediaRecorder
https://bugs.webkit.org/show_bug.cgi?id=190018

Attachment 351576: Patch

https://bugs.webkit.org/attachment.cgi?id=351576&action=review




--- Comment #27 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 351576
  --> https://bugs.webkit.org/attachment.cgi?id=351576
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351576&action=review

> Source/WebCore/Modules/mediarecorder/MediaRecorder.cpp:57
> +    return false; // FIXME: Implement this function to solve the crash
issue.

This comment is wrong, this should NOT cause any crashes, this is merely
inefficient as it prevents PageCache. The comment should be something like.
// FIXME: We should do better here as this prevents entering PageCache.