[webkit-reviews] review granted: [Bug 190266] Add support for reporting "display composited video frames" through the VideoPlaybackQuality object. : [Attachment 351568] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 190266: Add support for reporting "display composited video frames" through
the VideoPlaybackQuality object.
https://bugs.webkit.org/show_bug.cgi?id=190266

Attachment 351568: Patch

https://bugs.webkit.org/attachment.cgi?id=351568&action=review




--- Comment #5 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 351568
  --> https://bugs.webkit.org/attachment.cgi?id=351568
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351568&action=review

r=me once the bots are happy

> Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h:38
> +    static Ref<VideoPlaybackQuality> create(double creationTime, const
VideoPlaybackQualityMetrics&);

VideoPlaybackQualityMetrics&& ?

> Source/WebCore/Modules/mediasource/VideoPlaybackQuality.h:48
> +    VideoPlaybackQuality(double creationTime, const
VideoPlaybackQualityMetrics&);

Ditto