[webkit-reviews] review granted: [Bug 190258] Gtk build fails with python 3 if LANG and LC_TYPE are unset : [Attachment 351542] Proposed patch.

[bugzilla-daemon at webkit.org]

Konstantin Tokarev <annulen at yandex.ru> has granted  review:
Bug 190258: Gtk build fails with python 3 if LANG and LC_TYPE are unset
https://bugs.webkit.org/show_bug.cgi?id=190258

Attachment 351542: Proposed patch.

https://bugs.webkit.org/attachment.cgi?id=351542&action=review




--- Comment #5 from Konstantin Tokarev <annulen at yandex.ru> ---
Comment on attachment 351542
  --> https://bugs.webkit.org/attachment.cgi?id=351542
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=351542&action=review

>>> Source/JavaScriptCore/Scripts/cssmin.py:51
>>> +	     sys.stdout = io.TextIOWrapper(sys.stdout.buffer, encoding='UTF-8')
>> 
>> These lines duplicate code above
> 
> I think you're referring to this line:
>	   sys.stdin = io.TextIOWrapper(sys.stdin.buffer, encoding='UTF-8')
> My patch adds similar handling for sys.stdout.

Oh, sorry. Still I think it would be better to avoid duplication of
'sys.version_info[0] >= 3' and 'import io' to prevent misreads