[webkit-reviews] review granted: [Bug 190270] [Cocoa] Let clients specify an NSFileWrapper subclassed to be used for _WKAttachment : [Attachment 351571] Add _attachmentFileWrapperClass property to WKWebViewConfiguration

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Oct 3 18:27:30 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted mitz at webkit.org's request for
review:
Bug 190270: [Cocoa] Let clients specify an NSFileWrapper subclassed to be used
for _WKAttachment
https://bugs.webkit.org/show_bug.cgi?id=190270

Attachment 351571: Add _attachmentFileWrapperClass property to
WKWebViewConfiguration

https://bugs.webkit.org/attachment.cgi?id=351571&action=review




--- Comment #3 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 351571
  --> https://bugs.webkit.org/attachment.cgi?id=351571
Add _attachmentFileWrapperClass property to WKWebViewConfiguration

View in context: https://bugs.webkit.org/attachment.cgi?id=351571&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:1456
> +    NSPasteboard *pasteboard = NSPasteboard.generalPasteboard;

This is in cross-platform code! Could you just use one of the platform helper
functions to write something to the pasteboard (e.g. platformCopyPNG(),
platformCopyRichTextWithMultipleAttachments(), etc.) so we can run this on iOS
as well?


More information about the webkit-reviews mailing list