[webkit-reviews] review granted: [Bug 190051] Add a quirk to disable Modern EME for sites which are broken with it enabled : [Attachment 351294] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has granted Jer Noble <jer.noble at apple.com>'s
request for review:
Bug 190051: Add a quirk to disable Modern EME for sites which are broken with
it enabled
https://bugs.webkit.org/show_bug.cgi?id=190051

Attachment 351294: Patch

https://bugs.webkit.org/attachment.cgi?id=351294&action=review




--- Comment #19 from Daniel Bates <dbates at webkit.org> ---
Comment on attachment 351294
  --> https://bugs.webkit.org/attachment.cgi?id=351294
Patch

I am not happy with this patch. If there is another Encrypted Media API expert
that can ascertain whether this is patch represents the only choice we have to
fixing the domains hardcoded in the patch then I would prefer they take a look
at this. This patch will hinder the web author behind the domains hardcoded in
this patch from fixing their site so as to Encrypted Media API until the next
shipped release of WebKit. If there was a more surgical way to detect the bad
usage of the Encrypted Media API and fix up these hardcoded sites then that
would be preferable than an outright ban. From what Jer Noble has told me on
IRC this patch represents the best approach to solving the media issues on the
effected site together with evangelism.