[webkit-reviews] review granted: [Bug 190228] [JSC] print() changes CRLF to CRCRLF on Windows : [Attachment 351553] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Ross Kirsling
<ross.kirsling at sony.com>'s request for review:
Bug 190228: [JSC] print() changes CRLF to CRCRLF on Windows
https://bugs.webkit.org/show_bug.cgi?id=190228

Attachment 351553: Patch

https://bugs.webkit.org/attachment.cgi?id=351553&action=review




--- Comment #2 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 351553
  --> https://bugs.webkit.org/attachment.cgi?id=351553
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351553&action=review

> Source/JavaScriptCore/jsc.cpp:2236
> +    _setmode(1, _O_BINARY);
> +    _setmode(2, _O_BINARY);

Would it be possible to use _fileno(stdout) and _fileno(stderr) instead?  I
think that those documents the intent better than 1 and 2.