[webkit-reviews] review granted: [Bug 190257] [Web Animations] REGRESSION: setting 'animation-name: none' after a 'fill: forwards' animation has completed does not revert to the unanimated style : [Attachment 351541] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Oct 3 12:17:34 PDT 2018
Dean Jackson <dino at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 190257: [Web Animations] REGRESSION: setting 'animation-name: none' after a
'fill: forwards' animation has completed does not revert to the unanimated
style
https://bugs.webkit.org/show_bug.cgi?id=190257
Attachment 351541: Patch
https://bugs.webkit.org/attachment.cgi?id=351541&action=review
--- Comment #3 from Dean Jackson <dino at apple.com> ---
Comment on attachment 351541
--> https://bugs.webkit.org/attachment.cgi?id=351541
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=351541&action=review
> Source/WebCore/animation/AnimationTimeline.cpp:479
> ASSERT(animation);
If this is always non-null, can the parameter be a Ref<>?
> Source/WebCore/animation/DeclarativeAnimation.h:45
> + Element& target() const { return m_target; }
Can this be const Element&?
> LayoutTests/animations/animation-fill-forwards-removal.html:20
> + assert_equals(getComputedStyle(target).marginLeft, "100px", "The
target element has style values from the final keyframe of its animation.");
Have events always fired after we update the final style? I guess so.
More information about the webkit-reviews
mailing list