[webkit-reviews] review denied: [Bug 187039] Add support for testdriver WPT tests : [Attachment 351410] Patch

[bugzilla-daemon at webkit.org]

Frédéric Wang (:fredw) <fred.wang at free.fr> has denied darshan
<dkadu at igalia.com>'s request for review:
Bug 187039: Add support for testdriver WPT tests
https://bugs.webkit.org/show_bug.cgi?id=187039

Attachment 351410: Patch

https://bugs.webkit.org/attachment.cgi?id=351410&action=review




--- Comment #6 from Frédéric Wang (:fredw) <fred.wang at free.fr> ---
Comment on attachment 351410
  --> https://bugs.webkit.org/attachment.cgi?id=351410
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351410&action=review

> LayoutTests/ChangeLog:8
> +	   * TestExpectations:

It would be nice to give details about the change in the changelog. e.g. IIUC
you plan not to include any macOS/iOS implementation yet in this bug?

>> LayoutTests/TestExpectations:-858
>> -webkit.org/b/187039
imported/w3c/web-platform-tests/infrastructure/testdriver [ Skip ] # testdriver
not supported yet.
> 
> If we are unskipping these tests, we should be running these tests, but they
do not have -expected.txt so I am unsure what happens there.

Yes, please run the tests and add the expectation files.

> LayoutTests/imported/w3c/web-platform-tests/resources/testdriver-vendor.js:2
> +    window.test_driver_internal.click =  function(element, coords){

the spacing around { and = operators does not look correct in this file. Please
check how it is done for testdriver.js