[webkit-reviews] review granted: [Bug 190167] Enable H264 simulcast : [Attachment 351495] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted youenn fablet
<youennf at gmail.com>'s request for review:
Bug 190167: Enable H264 simulcast
https://bugs.webkit.org/show_bug.cgi?id=190167

Attachment 351495: Patch

https://bugs.webkit.org/attachment.cgi?id=351495&action=review




--- Comment #10 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 351495
  --> https://bugs.webkit.org/attachment.cgi?id=351495
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351495&action=review

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/PeerConnec
tion/RTCDefaultVideoDecoderFactory.mm:40
> +    [[RTCVideoCodecInfo alloc] initWithName:kRTCVideoCodecVp8Name],

#if !defined(RTC_DISABLE_VP8) ?

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/PeerConnec
tion/RTCDefaultVideoEncoderFactory.mm:43
> +  RTCVideoCodecInfo *vp8Info = [[RTCVideoCodecInfo alloc]
initWithName:kRTCVideoCodecVp8Name];

Ditto.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/PeerConnec
tion/RTCDefaultVideoEncoderFactory.mm:52
> +    vp8Info,

Ditto.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:897
> +

Nit: unneeded

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:922
> +	   auto codec = [[RTCSingleVideoEncoderH264 alloc] initWithCodecInfo:
_codecInfo simulcastIndex:index];
> +	   [_codecs addObject: codec];

Nit: space after ":" not needed.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:934
> +	   [codec startEncodeWithSettings: settings numberOfCores:
numberOfCores];

Ditto.

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:949
> +	   result |= [codec encode: frame codecSpecificInfo: info frameTypes:
frameTypes];

Ditto

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Classes/VideoToolb
ox/RTCVideoEncoderH264.mm:957
> +	   result |= [codec setBitrate:
bitRateAllocation->GetSpatialLayerSum(counter++) framerate: framerate];

Ditto

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Headers/WebRTC/RTC
VideoCodec.h:165
> +- (int)setRateAllocation: (const webrtc::VideoBitrateAllocation *)allocation
framerate:(uint32_t)framerate;

Ditto

>
Source/ThirdParty/libwebrtc/Source/webrtc/sdk/objc/Framework/Native/src/objc_vi
deo_encoder_factory.mm:94
> +    return [encoder_ setRateAllocation: &allocation framerate:framerate];

Ditto