[webkit-reviews] review granted: [Bug 190221] Web Automation: tab default key handler should always cycle focus when page is controlled by automation : [Attachment 351445] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 190221: Web Automation: tab default key handler should always cycle focus
when page is controlled by automation
https://bugs.webkit.org/show_bug.cgi?id=190221

Attachment 351445: Patch

https://bugs.webkit.org/attachment.cgi?id=351445&action=review




--- Comment #3 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 351445
  --> https://bugs.webkit.org/attachment.cgi?id=351445
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351445&action=review

r=me

> Source/WebCore/ChangeLog:15
> +	   Always cycle focus if the page is controlled by automation. If the
chrome takes
> +	   focus, then the first responder will be something other than the
WebView, which
> +	   causes subsequent WebDriver commands to hang.

Hmm, this is interesting and makes sense but doesn't that mean that the test
might differ from a real user behavior on the page?