[webkit-reviews] review granted: [Bug 189708] Separate configuration extraction from offset extraction : [Attachment 350734] Patch

[bugzilla-daemon at webkit.org]

Keith Miller <keith_miller at apple.com> has granted Tadeu Zagallo
<tzagallo at apple.com>'s request for review:
Bug 189708: Separate configuration extraction from offset extraction
https://bugs.webkit.org/show_bug.cgi?id=189708

Attachment 350734: Patch

https://bugs.webkit.org/attachment.cgi?id=350734&action=review




--- Comment #14 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 350734
  --> https://bugs.webkit.org/attachment.cgi?id=350734
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=350734&action=review

r=me with comments.

> Source/JavaScriptCore/CMakeLists.txt:250
>      DEPENDS ${LLINT_ASM} ${OFFLINE_ASM}
${DERIVED_SOURCES_JAVASCRIPTCORE_DIR}/InitBytecodes.asm

I think this needs to depend on the result of the add_executable for
LLIntSettingsExtractor?

> Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb:49
> +    $stderr.puts "OffsetExtractor: No magic values found. Skipping assembly
file generation."

Nit: Shouldn't this be "OffsetExtractor: No magic values found. Skipping
offsets extractor file generation."?