[webkit-reviews] review denied: [Bug 190195] User installed fonts are not always disabled when they should be : [Attachment 351373] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 2 11:31:45 PDT 2018


Myles C. Maxfield <mmaxfield at apple.com> has denied  review:
Bug 190195: User installed fonts are not always disabled when they should be
https://bugs.webkit.org/show_bug.cgi?id=190195

Attachment 351373: patch

https://bugs.webkit.org/attachment.cgi?id=351373&action=review




--- Comment #7 from Myles C. Maxfield <mmaxfield at apple.com> ---
Comment on attachment 351373
  --> https://bugs.webkit.org/attachment.cgi?id=351373
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351373&action=review

> Source/WebCore/platform/graphics/FontDescription.cpp:83
> -    ,
m_shouldAllowUserInstalledFonts(static_cast<unsigned>(AllowUserInstalledFonts::
Yes))
> +    ,
m_shouldAllowUserInstalledFonts(static_cast<unsigned>(AllowUserInstalledFonts::
No))

The default setting for WKWebViews (and regular WebViews) is that
user-installed fonts are allowed. Changing the default will cause tons of
native apps to break.


More information about the webkit-reviews mailing list