[webkit-reviews] review granted: [Bug 190208] clang Linux build cannot link because of __builtin_mul_overflow : [Attachment 351411] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Oct 2 10:33:22 PDT 2018


Mark Lam <mark.lam at apple.com> has granted Olivier Blin
<olivier.blin at softathome.com>'s request for review:
Bug 190208: clang Linux build cannot link because of __builtin_mul_overflow
https://bugs.webkit.org/show_bug.cgi?id=190208

Attachment 351411: Patch

https://bugs.webkit.org/attachment.cgi?id=351411&action=review




--- Comment #3 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 351411
  --> https://bugs.webkit.org/attachment.cgi?id=351411
Patch

r=me I saw Michael's concern but I think it's OK here because no one else needs
it except for this code.  I agree that it is good form to #undef it at the
bottom of the file (especially because we build with unified sources).


More information about the webkit-reviews mailing list