[webkit-reviews] review denied: [Bug 190196] [GTK] Enable more Cache Storage and Service Workers tests : [Attachment 351379] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has denied Frédéric Wang (:fredw)
<fred.wang at free.fr>'s request for review:
Bug 190196: [GTK] Enable more Cache Storage and Service Workers tests
https://bugs.webkit.org/show_bug.cgi?id=190196

Attachment 351379: Patch

https://bugs.webkit.org/attachment.cgi?id=351379&action=review




--- Comment #2 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 351379
  --> https://bugs.webkit.org/attachment.cgi?id=351379
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351379&action=review

>
LayoutTests/platform/gtk/http/wpt/cache-storage/cache-quota.any-expected.txt:6
> +FAIL Hitting cache quota for non opaque responses assert_unreached: Reached
unreachable code
> +FAIL Hitting cache quota for padded responses assert_unreached: Reached
unreachable code

Yeah, I'm not really comfortable with having this in the expected results. I
think this should be marked as Gailure

>
LayoutTests/platform/gtk/imported/w3c/web-platform-tests/service-workers/servic
e-worker/registration-script.https-expected.txt:3
> +FAIL Registering invalid chunked encoding script assert_unreached: Should
have rejected: Registration of invalid chunked encoding script should fail.
Reached unreachable code
> +FAIL Registering invalid chunked encoding script with flush
assert_unreached: Should have rejected: Registration of invalid chunked
encoding script should fail. Reached unreachable code

Ditto