[webkit-reviews] review granted: [Bug 190143] [MSE][GStreamer] Add h264parse to accept MP4 without stss : [Attachment 351361] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 190143: [MSE][GStreamer] Add h264parse to accept MP4 without stss
https://bugs.webkit.org/show_bug.cgi?id=190143

Attachment 351361: Patch

https://bugs.webkit.org/attachment.cgi?id=351361&action=review




--- Comment #6 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 351361
  --> https://bugs.webkit.org/attachment.cgi?id=351361
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351361&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:872
> +	   GstElement* h264parse = gst_element_factory_make("h264parse",
parserName.get());
> +	   g_return_val_if_fail(h264parse, nullptr);

ASSERT on the element as well to get a crash in debug.