[webkit-reviews] review granted: [Bug 190142] [MediaStream] RealtimeMediaSource should be able to vend hashed IDs : [Attachment 351346] Updated patchh

[bugzilla-daemon at webkit.org]

youenn fablet <youennf at gmail.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 190142: [MediaStream] RealtimeMediaSource should be able to vend hashed IDs
https://bugs.webkit.org/show_bug.cgi?id=190142

Attachment 351346: Updated patchh

https://bugs.webkit.org/attachment.cgi?id=351346&action=review




--- Comment #6 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 351346
  --> https://bugs.webkit.org/attachment.cgi?id=351346
Updated patchh

View in context: https://bugs.webkit.org/attachment.cgi?id=351346&action=review

> Source/WebCore/Modules/mediastream/MediaDevicesRequest.cpp:122
>	   document.setDeviceIDHashSalt(deviceIdentifierHashSalt);

Maybe move the ASSERT in document.setDeviceIDHashSalt.

> Source/WebCore/platform/mediastream/RealtimeMediaSource.cpp:58
> +    else

ASSERT(!m_idHashSalt.isEmpty());

> Source/WebCore/platform/mediastream/RealtimeMediaSourceFactory.h:38
>  struct CaptureSourceOrError;

CaptureSourceOrError before.

>
Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoCaptureSource.cpp:2
45
> +	   capabilities.setDeviceId(hashedId());

Probably unneeded, let's remove it now or in a follow-up.

> Source/WebKit/UIProcess/Cocoa/UserMediaCaptureManagerProxy.cpp:128
> +void
UserMediaCaptureManagerProxy::createMediaSourceForCaptureDeviceWithConstraints(
uint64_t id, const CaptureDevice& device, WebCore::RealtimeMediaSource::Type
type, const String& hashSalt, const MediaConstraints& constraints, bool&
succeeded, String& invalidConstraints, WebCore::RealtimeMediaSourceSettings&
settings)

String&& hashSalt?