[webkit-reviews] review granted: [Bug 190117] [GTK] Theming of authentication dialog breaks with themes other than Adwaita : [Attachment 351315] Patch

[bugzilla-daemon at webkit.org]

Michael Catanzaro <mcatanzaro at igalia.com> has granted Adrian Perez
<aperez at igalia.com>'s request for review:
Bug 190117: [GTK] Theming of authentication dialog breaks with themes other
than Adwaita
https://bugs.webkit.org/show_bug.cgi?id=190117

Attachment 351315: Patch

https://bugs.webkit.org/attachment.cgi?id=351315&action=review




--- Comment #6 from Michael Catanzaro <mcatanzaro at igalia.com> ---
Comment on attachment 351315
  --> https://bugs.webkit.org/attachment.cgi?id=351315
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351315&action=review

So in the end we did not need to switch from "messagedialog" to "dialog"?

> Source/WebKit/ChangeLog:17
> +	   is uneeded because the style classes are set at widget construction

unneeded

> Source/WebKit/ChangeLog:23
> +	   (webkitWebViewDialogConstructed): Mark the widget as app-paintable
to
> +	   avoid the base widget paint operation to fill the whole background,
> +	   because the dialog widget paints the translucent overlay itself; and
> +	   also add the missing GTK_STYLE_CLASS_BACKGROUND class at
construction
> +	   when building against GTK+ 3.20 or newer.

I actually don't like the translucent overlay, though. It looks broken if you
visit some random website, then a different website that requires HTTP auth,
and the original website displays underneath in the background. There's no good
reason for this, and it could really confuse the user into thinking there is a
security problem.

But I guess we are talking about different overlays. I don't want the web
content to be visible. But of course I want the gray background to be visible.
And I'm sure that's what you're fixing here.