[webkit-reviews] review denied: [Bug 190143] [MSE][GStreamer] Add h264parse to accept MP4 without stss : [Attachment 351262] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has denied Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 190143: [MSE][GStreamer] Add h264parse to accept MP4 without stss
https://bugs.webkit.org/show_bug.cgi?id=190143

Attachment 351262: Patch

https://bugs.webkit.org/attachment.cgi?id=351262&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 351262
  --> https://bugs.webkit.org/attachment.cgi?id=351262
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351262&action=review

> Source/WebCore/platform/graphics/gstreamer/mse/AppendPipeline.cpp:872
> +	   RELEASE_ASSERT(h264parse);

Please, add a GST_ERROR, ASSERT_NOT_REACHED and return nullptr in case there is
no parser. Better a not playing element than a web process crass.

And we should do the same for vorbisparse.