[webkit-reviews] review granted: [Bug 189162] Make <input type=color> a runtime enabled (on-by-default) feature : [Attachment 348642] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 18:58:15 PDT 2018


Wenson Hsieh <wenson_hsieh at apple.com> has granted Aditya Keerthi
<pxlcoder at gmail.com>'s request for review:
Bug 189162: Make <input type=color> a runtime enabled (on-by-default) feature
https://bugs.webkit.org/show_bug.cgi?id=189162

Attachment 348642: Patch

https://bugs.webkit.org/attachment.cgi?id=348642&action=review




--- Comment #10 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 348642
  --> https://bugs.webkit.org/attachment.cgi?id=348642
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=348642&action=review

> Source/WebKit/UIProcess/mac/WebColorPickerMac.mm:56
> +    __weak id<WKPopoverColorWellDelegate> _webDelegate;

I think we typically use WeakObjCPtr for this.


More information about the webkit-reviews mailing list