[webkit-reviews] review granted: [Bug 190128] [WinCairo] Enable WPT tests environment. : [Attachment 351241] PATCH

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 13:52:26 PDT 2018


youenn fablet <youennf at gmail.com> has granted Basuke Suzuki
<Basuke.Suzuki at sony.com>'s request for review:
Bug 190128: [WinCairo] Enable WPT tests environment.
https://bugs.webkit.org/show_bug.cgi?id=190128

Attachment 351241: PATCH

https://bugs.webkit.org/attachment.cgi?id=351241&action=review




--- Comment #2 from youenn fablet <youennf at gmail.com> ---
Comment on attachment 351241
  --> https://bugs.webkit.org/attachment.cgi?id=351241
PATCH

View in context: https://bugs.webkit.org/attachment.cgi?id=351241&action=review

> Tools/Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:122
> +	       config_json =
self._filesystem.read_text_file(config_wk_filename).replace("%CERTS_DIR%",
self._filesystem.join(self._output_dir, "_wpt_certs").replace('\\', '\\\\'))

Would it work to use json.dumps instead?
Something like:
s/self._filesystem.join(self._output_dir, "_wpt_certs").replace('\\',
'\\\\')/json.dumps(self._filesystem.join(self._output_dir, "_wpt_certs"))/


More information about the webkit-reviews mailing list