[webkit-reviews] review denied: [Bug 188598] [JSC] Remove gcc warnings on mips and armv7 : [Attachment 351289] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Oct 1 13:12:53 PDT 2018


Mark Lam <mark.lam at apple.com> has denied Guillaume Emont
<guijemont at igalia.com>'s request for review:
Bug 188598: [JSC] Remove gcc warnings on mips and armv7
https://bugs.webkit.org/show_bug.cgi?id=188598

Attachment 351289: Patch

https://bugs.webkit.org/attachment.cgi?id=351289&action=review




--- Comment #30 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 351289
  --> https://bugs.webkit.org/attachment.cgi?id=351289
Patch

r- for now.  This patch cane be improved i.e. there's no need for the
IGNORE_CAST_ALIGN_WARNINGS macros at all.


More information about the webkit-reviews mailing list