[webkit-reviews] review granted: [Bug 190125] [MSE][GStreamer] Set a minimum sample size : [Attachment 351251] Patch

[bugzilla-daemon at webkit.org]

Xabier Rodríguez Calvar <calvaris at igalia.com> has granted Alicia Boya García
<aboya at igalia.com>'s request for review:
Bug 190125: [MSE][GStreamer] Set a minimum sample size
https://bugs.webkit.org/show_bug.cgi?id=190125

Attachment 351251: Patch

https://bugs.webkit.org/attachment.cgi?id=351251&action=review




--- Comment #2 from Xabier Rodríguez Calvar <calvaris at igalia.com> ---
Comment on attachment 351251
  --> https://bugs.webkit.org/attachment.cgi?id=351251
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=351251&action=review

> Source/WebCore/platform/graphics/gstreamer/MediaSampleGStreamer.cpp:59
> +	   m_duration = createMediaTime(std::max(GST_BUFFER_DURATION(buffer),
minimumDuration));

I'd recommend moving this above to a more prominent position than inside this
method.