[webkit-reviews] review requested: [Bug 190141] Swizzle +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner and DumpRenderTree : [Attachment 351256] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 190141: Swizzle +[UIKeyboard isInHardwareKeyboardMode] in WebKitTestRunner
and DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=190141

Attachment 351256: Patch

https://bugs.webkit.org/attachment.cgi?id=351256&action=review




--- Comment #1 from Daniel Bates <dbates at webkit.org> ---
Created attachment 351256

  --> https://bugs.webkit.org/attachment.cgi?id=351256&action=review

Patch

I shared the swizzling logic between DumpRenderTree and WebKitTestRunner by
adding new files SwizzleUIKit.{h, mm} to TestRunnerShared. I am open to naming
suggestions for these files as well as the function swizzleUIKit(), which does
the actual swizzling. Let me know if it is preferred to make SwizzleUIKit a
pure Objective-C file (.m) as opposed to an Objective-C++ file.