[webkit-reviews] review granted: [Bug 190108] Add a new variant of serializePreservingVisualAppearance which takes VisibleSelection : [Attachment 351226] Updated for trunk

[bugzilla-daemon at webkit.org]

Wenson Hsieh <wenson_hsieh at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 190108: Add a new variant of serializePreservingVisualAppearance which
takes VisibleSelection
https://bugs.webkit.org/show_bug.cgi?id=190108

Attachment 351226: Updated for trunk

https://bugs.webkit.org/attachment.cgi?id=351226&action=review




--- Comment #5 from Wenson Hsieh <wenson_hsieh at apple.com> ---
Comment on attachment 351226
  --> https://bugs.webkit.org/attachment.cgi?id=351226
Updated for trunk

View in context: https://bugs.webkit.org/attachment.cgi?id=351226&action=review

> Source/WebCore/platform/win/PasteboardWin.cpp:472
> +	   // FIXME: Use ResolveURLs::YesExcludingLocalFileURLsForPrivacy

Nit - period at end of this comment.

> Source/WebKit/WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:125
>      pasteboardContent.text = range->text();

It looks like this GTK code still grabs text from the selected Range — perhaps
we could just keep the VisibleSelection => Range conversion here to call
Range::text(), or add a variant of plainText() in TextIterator.h that takes a
VisibleSelection instead of a Range and call that instead.