[webkit-reviews] review granted: [Bug 191608] [iOS] Do not handle key events that are key commands : [Attachment 356254] Patch and layout tests

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Daniel Bates <dbates at webkit.org>'s
request for review:
Bug 191608: [iOS] Do not handle key events that are key commands
https://bugs.webkit.org/show_bug.cgi?id=191608

Attachment 356254: Patch and layout tests

https://bugs.webkit.org/attachment.cgi?id=356254&action=review




--- Comment #11 from Ryosuke Niwa <rniwa at webkit.org> ---
Comment on attachment 356254
  --> https://bugs.webkit.org/attachment.cgi?id=356254
Patch and layout tests

View in context: https://bugs.webkit.org/attachment.cgi?id=356254&action=review

> LayoutTests/fast/events/ios/key-command-italic-dispatches-keydown.html:13
> +    user-modify: read-write;
> +    -webkit-user-modify: read-write;

Remove these as we discussed in person.

> LayoutTests/fast/events/ios/key-command-italic-dispatches-keydown.html:46
> +    window.event = event;

We shouldn't have this useless code since window.event is defined here.

> LayoutTests/fast/events/ios/key-command-italic.html:8
> +Markup.waitUntilDone();

It's unnecessary to have a separate script element to call waitUntilDone. Just
do it in the other script element.

> LayoutTests/fast/events/ios/key-command-italic.html:16
> +    user-modify: read-write;
> +    -webkit-user-modify: read-write;

Ditto.

> LayoutTests/fast/events/ios/type-digits-holding-control-key.html:7
> +let charactersToType = "1234567890".split("");

Use const?

> LayoutTests/fast/events/ios/type-digits-holding-control-key.html:8
> +for (let c of charactersToType)

Use const?