[webkit-reviews] review granted: [Bug 192200] CSS Painting API should allow image values in inputProperties : [Attachment 356135] Patch

Fri Nov 30 15:39:59 PST 2018

Dean Jackson <dino at apple.com> has granted Justin Michaud
<justin_michaud at apple.com>'s request for review:
Bug 192200: CSS Painting API should allow image values in inputProperties
https://bugs.webkit.org/show_bug.cgi?id=192200

Attachment 356135: Patch

https://bugs.webkit.org/attachment.cgi?id=356135&action=review

--- Comment #7 from Dean Jackson <dino at apple.com> ---
Comment on attachment 356135
  --> https://bugs.webkit.org/attachment.cgi?id=356135
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356135&action=review

> Source/WebCore/platform/graphics/gpu/GPUSwapChain.h:32
> +#include "GPUTexture.h"
>  #include <wtf/RefPtr.h>
>  #include <wtf/RetainPtr.h>

OOPS. Not meant for this patch.

> LayoutTests/fast/css-custom-paint/arguments.html:6
> +<!DOCTYPE html><!-- webkit-test-runner [
experimental:CSSPaintingAPIEnabled=true ] -->
> +<meta name="author" title="Justin Michaud"
href="mailto:justin_michaud at webkit.org">
> +<meta name="assert" content="Test that paint worklets parse arguments
correctly">
> +<link rel="help" content="https://drafts.css-houdini.org/css-paint-api-1/">
> +<script src="resources/testharness.js"></script>
> +

I don't think this test has anything to do with this patch.