[webkit-reviews] review granted: [Bug 192255] Web Inspector: resource combining should be more robust against missing WebKitAdditions : [Attachment 356236] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Brian Burg <bburg at apple.com>'s
request for review:
Bug 192255: Web Inspector: resource combining should be more robust against
missing WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=192255

Attachment 356236: Patch

https://bugs.webkit.org/attachment.cgi?id=356236&action=review




--- Comment #4 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 356236
  --> https://bugs.webkit.org/attachment.cgi?id=356236
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356236&action=review

r=me

>> Source/WebInspectorUI/Scripts/copy-user-interface-resources.pl:250
>> +	    $combineWebKitAdditions = 1 if $foundCSSFile and $foundJSFile;
> 
> Should this be "and", or "or"?
> 
> I'll leave actual reviewing to folks who know more about this logic and/or
about Perl.

Same question, I think an `or` might make sense here, as long as there is
something we may want to proceed.