[webkit-reviews] review granted: [Bug 192256] Stop using a global singleton for NetworkCapture::Manager : [Attachment 356240] Patch

[bugzilla-daemon at webkit.org]

Chris Dumez <cdumez at apple.com> has granted Alex Christensen
<achristensen at apple.com>'s request for review:
Bug 192256: Stop using a global singleton for NetworkCapture::Manager
https://bugs.webkit.org/show_bug.cgi?id=192256

Attachment 356240: Patch

https://bugs.webkit.org/attachment.cgi?id=356240&action=review




--- Comment #2 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 356240
  --> https://bugs.webkit.org/attachment.cgi?id=356240
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=356240&action=review

> Source/WebKit/NetworkProcess/capture/NetworkCaptureRecorder.h:46
> +    Recorder(Manager& manager)

explicit ?

> Source/WebKit/NetworkProcess/capture/NetworkCaptureReplayer.h:45
> +    Replayer(Manager& manager)

explicit ?

> Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm:73
> +    auto replayMode = [] (String mode) -> std::optional<NetworkCaptureMode>
{

const String&