[webkit-reviews] review granted: [Bug 192190] Add first-class support for .mjs files in jsc binary : [Attachment 356189] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 30 11:07:45 PST 2018
Keith Miller <keith_miller at apple.com> has granted Dean Jackson
<dino at apple.com>'s request for review:
Bug 192190: Add first-class support for .mjs files in jsc binary
https://bugs.webkit.org/show_bug.cgi?id=192190
Attachment 356189: Patch
https://bugs.webkit.org/attachment.cgi?id=356189&action=review
--- Comment #3 from Keith Miller <keith_miller at apple.com> ---
Comment on attachment 356189
--> https://bugs.webkit.org/attachment.cgi?id=356189
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=356189&action=review
r=me with fix.
> Source/JavaScriptCore/jsc.cpp:2577
> +static int isMJSFile(char *filename)
This should return a bool.
More information about the webkit-reviews
mailing list