[webkit-reviews] review granted: [Bug 192216] Web Inspector: replace all unicode characters with the escaped character code : [Attachment 356161] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 30 09:21:03 PST 2018
Brian Burg <bburg at apple.com> has granted Devin Rousso <drousso at apple.com>'s
request for review:
Bug 192216: Web Inspector: replace all unicode characters with the escaped
character code
https://bugs.webkit.org/show_bug.cgi?id=192216
Attachment 356161: Patch
https://bugs.webkit.org/attachment.cgi?id=356161&action=review
--- Comment #11 from Brian Burg <bburg at apple.com> ---
Comment on attachment 356161
--> https://bugs.webkit.org/attachment.cgi?id=356161
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=356161&action=review
r=me
This will cause a lot of churn for localizers, but it's probably better that
the current state of things considering that our code review tools don't render
unicode correctly.
> Source/WebInspectorUI/UserInterface/Views/DebuggerDashboardView.css:178
> + content: "\00A0\2014\00A0";
Please keep the comment.
> Source/WebInspectorUI/UserInterface/Views/ErrorObjectView.js:58
> + span.textContent = ` ${emDash} `;
Nice.
> Source/WebInspectorUI/UserInterface/Views/ScriptDetailsTimelineView.css:52
> }
I'm not sure what these codepoints do. I would like a comment when its
something fairly unique.
> Source/WebInspectorUI/UserInterface/Views/TextEditor.css:78
> + content: "\2022\2022\2022";
Ditto
> Source/WebInspectorUI/UserInterface/Views/TreeOutline.css:256
> }
Ditto
More information about the webkit-reviews
mailing list