[webkit-reviews] review granted: [Bug 192075] [GStreamer][EME] CDMInstance should be shipped as a GstContext to the decryptors : [Attachment 356023] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Nov 30 06:54:40 PST 2018
Philippe Normand <pnormand at igalia.com> has granted Xabier RodrÃguez Calvar
<calvaris at igalia.com>'s request for review:
Bug 192075: [GStreamer][EME] CDMInstance should be shipped as a GstContext to
the decryptors
https://bugs.webkit.org/show_bug.cgi?id=192075
Attachment 356023: Patch
https://bugs.webkit.org/attachment.cgi?id=356023&action=review
--- Comment #15 from Philippe Normand <pnormand at igalia.com> ---
Comment on attachment 356023
--> https://bugs.webkit.org/attachment.cgi?id=356023
Patch
View in context: https://bugs.webkit.org/attachment.cgi?id=356023&action=review
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1209
> + if (!m_pipeline) {
> + GST_ERROR("no pipeline yet");
> + ASSERT_NOT_REACHED();
> + return;
> }
Replace this with a RELEASE_ASSERT_WITH_MESSAGE() maybe?
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1218
> + GST_DEBUG("CDM instance %p dispatched as context", m_cdmInstance.get());
GST_DEBUG_OBJECT()
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
1233
> + GST_DEBUG("detaching CDM instance %p, setting empty context",
m_cdmInstance.get());
GST_DEBUG_OBJECT
More information about the webkit-reviews
mailing list